RoomList: fix room scroll when clicked in thread activity centre#34179
Merged
Conversation
florianduros
changed the title
dbkr
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show_room_tileon theview_roomaction was a dead flag in the new room list: the Threads Activity Centre set it to ask the list to reveal a room, but nothing consumed it, so the list never scrolled.RoomListViewModelnow handlesview_roomwithshow_room_tileand scrolls the target room into view, reusing the imperative scroll handle the view already exposes (setScrollToIndex). If the room's section is collapsed, it is expanded first so the tile can actually be shown (matching the old room list's behaviour).